Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node.js 8, add TypeScript definition #1

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Require Node.js 8, add TypeScript definition #1

merged 2 commits into from
Apr 18, 2019

Conversation

BendingBender
Copy link
Contributor

@BendingBender BendingBender commented Apr 13, 2019 •
edited

sindresorhus
sindresorhus requested changes Apr 17, 2019
View reviewed changes
index.d.ts Outdated
declare namespace execall {
interface Match {
match: string;
sub: string[];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sub: string[];
sub: readonly string[];

Does it make sense to use readonly everywhere? I'm curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use it on returned values. They should be as flexible and consumer-friendly as possible.

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 473e984 into sindresorhus:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BendingBender @sindresorhus