-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iCalendar (ics) #173
Add support for iCalendar (ics) #173
Conversation
Looks good to me. Only thing you may want to add is the ics keyword in package.json. |
I know nothing of the iCalendar standard, but https://icalendar.org/validator.html returns some (9) errors in the fixture file. May be worth looking into. |
Looks good to me, it doesn't appear to obviously introduce any vulnerabilities, and Checkmarx scan of this branch comes back clean. |
@sripreddyg Can you make sure the fixture correctly passes https://icalendar.org/validator.html? |
Not followed.
Not followed. |
@sindresorhus Thanks for suggestions, I have fixed it. please review and approve if you are good with change |
If you're adding support for a new file type, please follow the below steps:
fixture.<extension>
to thefixture
directory.types
array intest.js
.index.js
file.Supported file types
section in the readme, in the format- [`<extension>`](URL) - Format name
, for example,- [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
keywords
array in thepackage.json
file.$ npm test
to ensure the tests pass.Add support for Format
, for example,Add support for PNG
.