Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iCalendar (ics) #173

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

sripreddyg
Copy link

If you're adding support for a new file type, please follow the below steps:

  • Add a fixture file named fixture.<extension> to the fixture directory.
  • Add the file extension to the types array in test.js.
  • Add the file type detection logic to the index.js file.
  • Add the file extension to the Supported file types section in the readme, in the format - [`<extension>`](URL) - Format name, for example, - [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
  • Add the file extension to the keywords array in the package.json file.
  • Run $ npm test to ensure the tests pass.
  • Open a pull request with a little like Add support for Format, for example, Add support for PNG.
  • The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes.

@ThomPattersonNM
Copy link

Looks good to me. Only thing you may want to add is the ics keyword in package.json.

@MaxLeiter
Copy link

MaxLeiter commented Nov 13, 2018

I know nothing of the iCalendar standard, but https://icalendar.org/validator.html returns some (9) errors in the fixture file. May be worth looking into.

@ghost
Copy link

ghost commented Nov 16, 2018

Looks good to me, it doesn't appear to obviously introduce any vulnerabilities, and Checkmarx scan of this branch comes back clean.

@sindresorhus
Copy link
Owner

@sripreddyg Can you make sure the fixture correctly passes https://icalendar.org/validator.html?

@sindresorhus
Copy link
Owner

Open a pull request with a little like Add support for Format, for example, Add support for PNG.

Not followed.

The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes.

Not followed.

@sripreddyg sripreddyg changed the title adding a support for iCalendar type Add support for ics Nov 19, 2018
@sripreddyg
Copy link
Author

@sindresorhus Thanks for suggestions, I have fixed it. please review and approve if you are good with change

@sindresorhus sindresorhus changed the title Add support for ics Add support for ics Nov 30, 2018
@sindresorhus sindresorhus changed the title Add support for ics Add support for iCalendar (ics) Nov 30, 2018
@sindresorhus sindresorhus merged commit d9186c9 into sindresorhus:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants