Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unnecessary dependency #458

Merged

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented May 24, 2021

Would like to remove the FileReader as well, but wasn't sure what browser you support

Closes #437

browser.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Removed a unnecessary dep Remove an unnecessary dependency May 24, 2021
@sindresorhus sindresorhus requested a review from Borewit May 24, 2021 12:53
Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sindresorhus sindresorhus merged commit 3df0ed1 into sindresorhus:main May 28, 2021
@jimmywarting jimmywarting deleted the remove-typedarray-to-buffer branch June 20, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read blob in nodejs
3 participants