Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure web-stream is released after detection #680

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Oct 13, 2024

@Borewit Borewit added the bug label Oct 13, 2024
@Borewit Borewit self-assigned this Oct 13, 2024
@sindresorhus
Copy link
Owner

CI is failing

@Borewit Borewit force-pushed the release-webstream-after-detection branch from d66aac0 to 2238d63 Compare October 13, 2024 17:25
@Borewit
Copy link
Collaborator Author

Borewit commented Oct 13, 2024

CI is failing

Release of strtok3 v9.0.1, will cause problems with file-type v19.5.0 (reason CI was failing). It exposes a the following issue:

file-type/index.js

Lines 13 to 17 in 0e91f7b

try {
return super.fromTokenizer(tokenizer);
} finally {
await tokenizer.close();
}

where the tokenizer is closed after return the promise, and not after resolving the promise.

Raised bug: #681

@sindresorhus sindresorhus merged commit 9945877 into main Oct 13, 2024
6 checks passed
@sindresorhus sindresorhus deleted the release-webstream-after-detection branch October 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment