Remove NodeFileTypeParser in favor of using FileTypeParser on all platforms
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
deprecate-class-NodeFileTypeParser
branch
from
8553091 to
f526ce6
Compare
|
I have no problem removing |
|
Just remove |
In Node.js class `FileTypeParser` shall contain the Node.js specific functions (`fromFile()`) as well.
Borewit
force-pushed
the
deprecate-class-NodeFileTypeParser
branch
from
f526ce6 to
81a150f
Compare
Borewit
added
the
API change
Borewit
changed the title
NodeFileTypeParserNodeFileTypeParser with FileTypeParser`
Borewit
changed the title
NodeFileTypeParser with FileTypeParser`NodeFileTypeParser with FileTypeParser
sindresorhus
changed the title
NodeFileTypeParser with FileTypeParserNodeFileTypeParser in favor of using FileTypeParser on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js class
FileTypeParsershall contain the Node.js specific functions (fromFile()) as well.Why: This simplify the usage and documentation of the
FileTypeParserclass.NodeFileTypeParserstill works, as this is defined as alias forFileTypeParser.