feat!: upgrade Node.js minimum supported version to 18 #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR upgrades pkg-dir ^7.0 to ^8.0, which reduces the dependencies tree and bandwidth consumption:
Before:
![image](https://private-user-images.githubusercontent.com/2103975/362571666-e556c493-df1b-4724-910e-aa2e2511e995.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDE1MDEsIm5iZiI6MTczOTI0MTIwMSwicGF0aCI6Ii8yMTAzOTc1LzM2MjU3MTY2Ni1lNTU2YzQ5My1kZjFiLTQ3MjQtOTEwZS1hYTJlMjUxMWU5OTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDIzMzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDk5MDNlN2MzYmRhZmYyMjU1M2E2N2FlNzljYzc2YzYxZWIyMWMxZmI1NGQyYjU5NWFiMzUzZjg4ZDJkZTlkZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.KigLldR7ZkmOqDNcpKZvge-zoRNw8MG_WSDTwIK1gX8)
After:
![image](https://private-user-images.githubusercontent.com/2103975/362571696-a2a38e02-f90d-4fb1-8a45-67009e3f7000.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDE1MDEsIm5iZiI6MTczOTI0MTIwMSwicGF0aCI6Ii8yMTAzOTc1LzM2MjU3MTY5Ni1hMmEzOGUwMi1mOTBkLTRmYjEtOGE0NS02NzAwOWUzZjcwMDAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDIzMzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDU2YzZlMGM3YjgyYTIyYWRjNzdkZjkwYjMxOGRhODFiMTk5ZWZiY2E0MjY5ZDJiOGJmNWViOGU1NzU3YzM5YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.x6Mx4vvYNR6fEMmOGg8gP-4xAn5NwaHk0SQoAXy8IE8)
Since pkg-dir@^8.0 requires Node.js 18, we must requires Node.js 18 here too. This update is a breaking change ... or not, depending if dropping a non-maintained version is a BC or not.
Thanks :)