Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignore package to latest version #92

Closed
alexander-akait opened this issue Nov 1, 2018 · 2 comments · Fixed by #120
Closed

Update ignore package to latest version #92

alexander-akait opened this issue Nov 1, 2018 · 2 comments · Fixed by #120
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted

Comments

@alexander-akait
Copy link

alexander-akait commented Nov 1, 2018

Issuehunt badges

There is a $20.00 open bounty on this issue. Add more on Issuehunt.

@sindresorhus
Copy link
Owner

sindresorhus commented Nov 2, 2018

I tried upgrading, but they changed some stuff and I don't have time to debug that right now. Help welcome.

https://github.com/kaelzhang/node-ignore#upgrade-4x---5x

gitignore › gitignore - sync

  /Users/sindresorhus/dev/oss/globby/node_modules/ignore/index.js:354

  Error thrown in test:

  RangeError {
    message: 'path should be a `path.relative()`d string, but got "../../foo.js"',
  }

  throwError (node_modules/ignore/index.js:354:9)
  checkPath (node_modules/ignore/index.js:375:12)
  Ignore._test (node_modules/ignore/index.js:483:5)
  Ignore.ignores (node_modules/ignore/index.js:518:17)
  p (gitignore.js:48:22)
  isIgnored (gitignore.test.js:16:54)
  Test.filter [as fn] (gitignore.test.js:16:38)

@sindresorhus sindresorhus changed the title update ignore package to latest version Update ignore package to latest version Nov 2, 2018
@IssueHuntBot
Copy link

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted
Projects
None yet
3 participants