Upgrade ignore dependency to version 5

[yaodingyd]

Fix #92

[sindresorhus]

I haven't look into this closely, but I always get suspicious when you have to modify tests to get something working. Are you sure this is the correct way to solve it? I would have thought we needed to do some changes to gitignore.js, like in

globby/gitignore.js

Line 48 in 71b9c58

return p => ignores.ignores(slash(path.relative(cwd, p)));

[sindresorhus]

https://github.com/kaelzhang/node-ignore#upgrade-4x---5x

[yaodingyd]

The 5x breaking change is that for every path it uses const REGEX_TEST_INVALID_PATH = /^\.*\/|^\.+$/ this regex to check invalid path and throws errors. So in the test case for "foo.js" after path.relative it returns ../../foo.js which throws errors. I want to confirm if globby is used, all the file paths from fastglob would be relative to current cwd and we would not have this issue, and all I need to do is take care of the test file?

Or we do need to consider this kind of path so in line 48 we need to check if path matches that regex?

[sindresorhus]

Or we do need to consider this kind of path so in line 48 we need to check if path matches that regex?

I don't know. Part of the task of fixing #92 is figuring that out.

[sindresorhus]

@yaodingyd Did you figure it out?

[yaodingyd]

I'm checking the input path: if it matches a relative path starting with ./ then I get relative path to cwd; otherwise I would pass it directly to ignore. I think my assumption makes sense: usually when we use globby, we would use it under cwd and any files path looks like the test ones, they should be under cwd, which is the results of path.relative, so that we can directly use them.

[sindresorhus]

Closing in favor of #20