Skip to content

Commit

Permalink
Allow specifying undefined for options (#2258)
Browse files Browse the repository at this point in the history
  • Loading branch information
WillianAgostini authored May 27, 2023
1 parent 0337311 commit 1cefe8b
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
8 changes: 7 additions & 1 deletion source/core/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,13 @@ export default class Options {
}

// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
this[key as keyof Options] = options[key as keyof Options];
const value = options[key as keyof Options];
if (value === undefined) {
continue;
}

// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
this[key as keyof Options] = value;

push = true;
}
Expand Down
14 changes: 14 additions & 0 deletions test/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,3 +205,17 @@ test('no socket hung up regression', withServer, async (t, server, got) => {

agent.destroy();
});

test('accept undefined agent', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.end('ok');
});

const undefinedAgent = undefined;
t.truthy((await got({
https: {
rejectUnauthorized: false,
},
agent: undefinedAgent,
})).body);
});

0 comments on commit 1cefe8b

Please sign in to comment.