Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Min/MAX TLS version and ciphers for requests #1299

Closed
1 task done
seiya-git opened this issue May 31, 2020 · 2 comments
Closed
1 task done

Set Min/MAX TLS version and ciphers for requests #1299

seiya-git opened this issue May 31, 2020 · 2 comments

Comments

@seiya-git
Copy link

What would you like to discuss?

How to set Min/MAX TLS version and ciphers for requests?

Checklist

  • I have read the documentation.
@Giotino
Copy link
Collaborator

Giotino commented May 31, 2020

Currently there's no official/documented way to do that (we could make a new PR like #1255).

An undocumented way could be using minVersion and maxVersion into the options. I don't know if it's going to work because, as you can see below, it's not present in the Node.JS documentation.

@szmarczak
In PR #1255 I implemeted the most used HTTPS options, but there were more:

The following additional options from tls.connect() are also accepted: ca, cert, ciphers, clientCertEngine, crl, dhparam, ecdhCurve, honorCipherOrder, key, passphrase, pfx, rejectUnauthorized, secureOptions, secureProtocol, servername, sessionIdContext, highWaterMark.

I can make a new PR with the remaining options.

I think all the tls.createSecureContext options could work even if undocumented.

@szmarczak
Copy link
Collaborator

There are Node.js command line options for that and those should suffice your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants