add .json to require('./package')

[janpio]

This fixes issues for people using got with webpack, which by default has problems with the missing extension.

I know that extensions are optional, but this simple change shouldn't cause any problems but would resolve the problem of all wbepack users trying to use got (or libraries using got).

I agree that normally libraries shouldn't have to adapt to the ecosystem, but in this case the code becomes even more readable and clearer (I at least didn't know that you could just leave off the file extension.)

Why not just use the workaround? Well, it seems to not work in all cases - and I found one of them.

[kevva]

There are plenty of closed issues about this already https://github.com/sindresorhus/got/search?q=package+json+webpack&type=Issues&utf8=%E2%9C%93. If the suggested solution doesn't work, I'd say it's something wrong with your configuration, or in ionic-app-scripts. This seems like it could cause it https://github.com/ionic-team/ionic-app-scripts/blob/master/config/optimization.config.js#L13-L15.

[janpio]

Fair enough.

But let me ask, what is so important with using the shortcut version without the filename? Is there a advantage?

[janpio]

Thanks for the pointer to the optimization.config.js - I wasn't aware of that and now created a PR to fix it.

[kevva]

But let me ask, what is so important with using the shortcut version without the filename? Is there a advantage?

There's no real reason to include the extension because of Webpack not being compatible with Node.js.