Add option to use modern API in dart-sass #312
Merged
+51
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not made changes to the workflow but have a further commit I can push that updates the GitHub action versions, drops testing on Node.js 8 and 10, and adds testing on Node.js 16,18 and 20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address #311.
It updates dependencies and moves to using sass (formerly dart-sass from node-sass since the latter is deprecated.
Tests are updated for layout and amended implementation of
slash as divisionas required for dart-sass since 1.33Lastly, the possibility to pass an option of
apiset asmodernis implemented. This will utilise the more up-to-date API functions pending the removal of the legacy API indart-sass2.0.0.