GH-87 Track gulp-plugin-extras as a regular dependency #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tracks
gulp-plugin-extrasas a regular dependency instead of a dev dependency.I think tests could not have caught this bug because the testing job in GH Actions installs all dependencies (i.e. not just regular dependencies). This is necessary in order to install testing utilities, so I’m not sure how to guard/protect against this kind of bug in the future. Happy to make adjustments to this PR if you have any ideas on how to protect against this.
Motivation
When
gulp-changedis installed in downstream projects, dev dependencies are ignored, resulting in failed builds whengulp-changedattempts to importgulp-plugin-extras, since the latter is currently tracked as a dev dependency.Closes #87.