Use yazl instead of JSZip

[kevva]

Also adds a test to check whether the zip has been created successfully or not by checking the contents.

[kevva]

Here are some benchmarks using this file https://gist.github.com/kevva/54d8c3d62a2bba256df8:

                      Create ZIP archive
             192 op/s » jszip
             900 op/s » yazl

[sindresorhus]

@kevva You told me to wait on merging this, but I can't remember the reason?

Merge conflict also needs to be fixed.

[kevva]

It seems to work fine by looking at the tests. I remember trying to extract the file using the archive manager on Ubuntu and it failed for some reason though. Using unzip worked though.

[sindresorhus]

@kevva Any open issue on yazl?

I don't want to use it if it has bugs as I will have to deal with them and JSZip seems to be working ok.

[kevva]

Nope, but I keep getting random write after end when testing now so I'll have to look into this further.

[rickychien]

Vote for yazl!

@kevva I ran into the same issue that my zip cannot be unzip properly Error 1 - operation not permittedby Archive Utility (default on Mac) but worked with The unarchiver or unzip.

[kevva]

@sindresorhus, I think this should be fine now. Tested and it seems to work with the Archive Manager (in Ubuntu) too.

[rickychien]

thejoshwolfe/yazl#14

It seems that OS X's issue has been fixed hours ago. It's time to merge this PR!

[kevva]

💃 More than 4x speed improvement!

[andrewrk]

you don't have to wait until the end callback to pipe the output stream. in fact, you can skip the zip.end function entirely - it's just to notify you when it knows the final size of the zip file.

[kevva]

I do think it's needed. I get timeout issues otherwise when running tests.

[andrewrk]

oh sorry, you do need to call it. but you don't need to wait for the callback.

[andrewrk]

Data becomes available in this stream soon after calling one of addFile(), addReadStream(), or
addBuffer(). Clients can call pipe() on this stream at any time, such as immediately after getting
a new ZipFile instance, or long after calling end().

from https://github.com/thejoshwolfe/yazl#outputstream

[kevva]

Yeah, makes no difference in speed or whatsoever though since we're only handling one buffer at a time.

[rickychien]

Could we update yazl to version 2.2.1 since it fixed on OS X
See also thejoshwolfe/yazl#14

[kevva]

@rickychien, ^2.1.0 will install 2.2.1.