Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide based on the resolved path #1

Closed
wants to merge 3 commits into from
Closed

decide based on the resolved path #1

wants to merge 3 commits into from

Conversation

thefourtheye
Copy link

as per @vkurchatkin's suggestion, made in nodejs/node#3307 (comment), this can be decided without a
predefined list of module names.

@sindresorhus
Copy link
Owner

I don't really see the benefit. This just adds a lot of overhead. Right now it uses process.binding('natives'). I hope by the time that API goes away, Node.js will have an officially exposed list of builtins, otherwise I'll just use the static list which most likely won't change much anyways.

@thefourtheye thefourtheye deleted the patch-1 branch March 28, 2016 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants