Fix onDownloadProgress
test commented out in test/browser.ts
#591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed a test that was commented out in browser.ts and fixed it.
When I uncommented it, I got a
ReferenceError: __name is not undefined
on playweight at the following locationOn playweight, it is executed as follows
I found out that this was due to an optimization option
keepNames
in vite.refs: vite/pull/2376#issuecomment-805285480, esbuild/issues/2605#issue-1404600925
In this repository, it seems to be happening only within playweight. I don't think there is any need to make it a function except for readability, so I fixed it so that it doesn't create a function.
Just to be sure, I tried it
onDownloadProgress
in a vite+react environment and the same thing did not happen, so it seems to be a good fix for testing only.