Accept a boolean for the removeQueryParameters option
#136
Conversation
index.js
Outdated
| @@ -187,6 +187,10 @@ const normalizeUrl = (urlString, options) => { | |||
| // Take advantage of many of the Node `url` normalizations | |||
| urlString = urlObj.toString(); | |||
|
|
|||
| if (options.removeQueryParameters === true) { | |||
| urlString = urlString.split('?')[0]; | |||
There was a problem hiding this comment.
This is not safe. Instead, modify the URL object.
| removeQueryParameters: false | ||
| }); | ||
| //=> 'http://www.sindresorhus.com/?foo=bar&ref=test_ref&utm_medium=test' | ||
| ``` |
There was a problem hiding this comment.
index.d.ts and readme should be fully in sync.
readme.md
Outdated
| //=> 'http://sindresorhus.com' | ||
| ``` | ||
|
|
||
| `false` will not remove any query parameter. Other options like `sortQueryParameters` are still applied when toggled. |
There was a problem hiding this comment.
I'm not sure I see the point of:
Other options like
sortQueryParametersare still applied when toggled.
That should already be obvious.
There was a problem hiding this comment.
Removed it.
sindresorhus
changed the title
removeQueryParameters boolean option - #133removeQueryParameters option
|
Thanks for the feedback. PR has been updated! |
index.js
Outdated
| @@ -173,6 +173,12 @@ const normalizeUrl = (urlString, options) => { | |||
| } | |||
| } | |||
|
|
|||
| if (options.removeQueryParameters === true) { | |||
| for (const key of [...urlObj.searchParams.keys()]) { | |||
There was a problem hiding this comment.
You can just set urlObj.search = '';.
There was a problem hiding this comment.
Nice, I didn't knew that. Changed it.
Everything is not resolved. |
Should all be resolved now. |
|
You still need to do https://github.com/sindresorhus/normalize-url/pull/136/files#r654795467 |
Should be fully in sync now. |
I saw issue #133 as unresolved so I went ahead and gave it a go.
removeQueryParametersboolean flag and implemented the new behaviorAny feedback is welcome.
Fixes #133