Add data URL support

[fisker]

fixes: #94 & #84

questions:

1. url data:text/plain;charset=UTF-8;,foo mentioned in Add support for data URLs #84, is not valid url accounding to valid-data-url, should I change Regex to loose strict one?
2. any more test cases need cover?
3. are we going to support other protocols like file: ftp: etc

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #94: Normalize data URLs

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[sindresorhus]

url data:text/plain;charset=UTF-8;,foo mentioned in #84, is not valid url accounding to valid-data-url, should I change Regex to loose strict one?

Yes, but make sure it's a valid data URL according to the spec first: https://tools.ietf.org/html/rfc2397

any more test cases need cover?

I can't really think of more cases.

are we going to support other protocols like file: ftp: etc

Would be useful to support file: as it's quite common. Not interested in supporting ftp though.

[sindresorhus]

Would be good to mention data URL support in the readme and index.d.ts. I don't think it's obvious.

[fisker]

Would be good to mention data URL support in the readme and index.d.ts. I don't think it's obvious.

Not sure how do you want to do this, add an example? or explain url parameter?

[sindresorhus]

or explain url parameter?

This

[fisker]

@sindresorhus ready to review

[sindresorhus]

Looks good :)

[fisker]

I just found I might made a mistake, accounding to MSDN https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs#Common_problems data URL don't support query strings

//cc @sindresorhus

[sindresorhus]

Would you be able to submit a PR with a fix? We should probably not do anything with the data part, so ignore all logic like query string, hash, path, etc.

[fisker]

Yes, working on it