Fix integration tests on GitHub Actions #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunysae
force-pushed
the
integration-test
branch
3 times, most recently
from
9df91b3
to
a1c2df0
Compare
bunysae
force-pushed
the
integration-test
branch
from
a1c2df0
to
3cd457d
Compare
|
Seems like you can just set the |
sindresorhus
changed the title
bunysae
force-pushed
the
integration-test
branch
from
d5ee306
to
2565f55
Compare
sindresorhus
reviewed
Dec 7, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus
reviewed
Dec 8, 2020
test/integration.js
Outdated
| if (process.env.GITHUB_ACTIONS) { | ||
| console.log('running on Github actions'); | ||
| await execa('git', ['config', '--global', 'user.name', 'Github actions']); | ||
| await execa('git', ['config', '--global', 'user.email', 'actions@github.com']); |
There was a problem hiding this comment.
This too you can do in the GH Actions file and not here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the breaking integration tests on Github actions. The checkout action on Travis CI fetches git submodules, whereas Github actions don't do it.