-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PowerShell on Windows for improved reliability #188
Conversation
Why not use |
I wanted to, and actually based this change on it (it uses powershell under the hood). However it doesn't support passing additional arguments to the underlying start command in powershell and therefore wouldn't allow implementing the wait/app options. |
With this change, I guess the |
It's up to you really, that would be a breaking API change, but it—theoretically—won't actually break any existing usages if it's removed. Let me know if you'd prefer to remove it as part of this change or not. |
We can remove it from the JS code, but it has to stay in the index.d.ts file (with a doc comment that it will be removed in the next major release). |
Fixes #173