-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output ESM instead of CommonJS #225
Conversation
CI is failing |
I'm willing to merge this now, but I won't release this until TS 4.5 final is out. |
yeah, it's a bit unfortunate that ts-node doesn't support typescript-4.5 beta TypeStrong/ts-node#1519 I think it would be compatible, just the semver (>=2.7) doesn't seem to allow beta release (4.5.0-beta) I've now changed |
I also needed to upgrade ava and xo so that they support esm, but I think everything should work now. Sorry that the pr is very big now :( |
message: (_, label, error) => typeof error === 'string' | ||
? `(${label}) ${error}` | ||
// eslint-disable-next-line @typescript-eslint/no-unsafe-call | ||
: error(label), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how to fix these two errors so I disabled them for now
CI is failing because of xojs/xo#599 |
Alright. XO is fixed now. Can you fix the tests? |
Node 14 CI Coverage is failing because of avajs/ava#2417 Node 16 CI Tests are failing because of ESM Loader Change in Node 16.12.0 (which was released yesterday), which breaks ts-node |
Updated ts-node, I think all should work now. |
I'm looking into why
Did you install using |
Posted about the cause of the xojs/xo#624 related issue in that PR. Though, as a separate issue, I don't think |
👏 🎉 |
TypeScript v4.5 has now been released, can this PR be released now @sindresorhus? |
Unfortunately not: #227 (comment) |
this would be a breaking change because of esm output
fixes #215