Switch from got to ky
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think there's a way to make it work. Users could set up a global proxy though, which may be a better solution. Not really something I care much about. |
tommy-mitchell
commented
Feb 20, 2024
Comment on lines
-8
to
-13
| // These agent options are chosen to match the npm client defaults and help with performance | ||
| // See: `npm config get maxsockets` and #50 | ||
| const agentOptions = { | ||
| keepAlive: true, | ||
| maxSockets: 50, | ||
| }; |
There was a problem hiding this comment.
is maxSockets relevant to ky? I added the keepalive option.
|
@sindresorhus I think #74 can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #75. Supersedes #74 and re-enables
tsdtests.How should proxy support work? Seeing as
kydoesn't support proxies: sindresorhus/ky#526package-json/index.js
Lines 55 to 65 in 7238462