Fix milliseconds rounding inconsistency #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
sindresorhus
requested changes
Nov 13, 2019
sindresorhus
changed the title
|
@explodingcamera are you planning on implementing the requested changes? If not, I don't mind implementing the fix. |
Signed-off-by: Henry Gressmann <mail@henrygressmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While everything below
0.1mskeeps the old behavior and gets rounded up to1ms, everything over that usesMath.round.Also fixes the issue with 11999 milliseconds rounding to
1m 60s.Fixes #38