Enhance time formatting with new hide options #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options `hideYears`, `hideYearsAndDays`, and `hideSeconds` to allow for more customizable time formatting.
sindresorhus
requested changes
Oct 29, 2024
|
Thanks for contributing. |
|
The readme needs to be updated too. |
Updated options "hideYears" to "hideYear" and "hideYearsAndDays" to "hideYearAndDays" for consistency. Also updated relevant code and tests to use the new option names.
Changed the hours calculation to use BigInt to handle large integers accurately. This ensures that the computation remains precise even when dealing with large numbers, enhancing the robustness of the code.
Included various configurations to test detailed time formatting including decimal seconds, sub-millisecond precision, and verbose modes. This ensures comprehensive coverage across different time display preferences.
Removed extra spaces in the comment blocks and aligned the `@default` lines correctly. This change improves code readability and consistency in the index.d.ts file.
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options
hideYears,hideYearsAndDays, andhideSecondsto allow for more customizable time formatting.Fixes #70