Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw CancelError if ipv6 resolves first #70

Merged
merged 4 commits into from
Mar 17, 2024

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Aug 9, 2023

Fixes #69

@doutatsu
Copy link

Anything I can do to help @Richienb? Would love to get this one sorted, as it's been polluting my error logs for awhile now 😫

@Richienb
Copy link
Contributor Author

@doutatsu Sure, let's collab. If you want, open a pr to https://github.com/Richienb/public-ip/tree/main-1 that adds mocks which cause the ipv4 promise to stall and the ipv6 promise to succeed, then test if its return value is as expected (like in the current tests which imply that no error is thrown).

@doutatsu
Copy link

doutatsu commented Sep 8, 2023

I decided to rollback instead for now, as I am a bit swamped to try and look into fixing this.

@sindresorhus
Copy link
Owner

Bump :)

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb marked this pull request as ready for review March 17, 2024 10:35
@Richienb
Copy link
Contributor Author

Relatively confident this will work but don't have ipv6 to test it

Richienb and others added 2 commits March 17, 2024 23:39
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus sindresorhus merged commit 5490c81 into sindresorhus:main Mar 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to handle exception for CancelError
3 participants