Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Git stash shows during git action #532

Closed
camsteffen opened this issue Feb 17, 2020 · 6 comments · Fixed by #535
Closed

Bug: Git stash shows during git action #532

camsteffen opened this issue Feb 17, 2020 · 6 comments · Fixed by #535
Labels
bug

Comments

@camsteffen
Copy link
Contributor

The git stash symbol shows during an interactive rebase or a merge (with conflicts). This happens even when I have not opted into the git stash symbol.
@camsteffen
Copy link
Contributor Author

Related #462

@sindresorhus
Copy link
Owner

// @carhartl

@carhartl
Copy link
Contributor

Funny, I had thought about that earlier. Looking into it!

@carhartl
Copy link
Contributor

So in general we don't want the symbol to appear during an action, correct?

carhartl added a commit to carhartl/pure that referenced this issue Feb 20, 2020
@carhartl
Fix stash symbol showing during git actions
c0e3fc2 
Closes sindresorhus#532
carhartl added a commit to carhartl/pure that referenced this issue Feb 20, 2020
@carhartl
Fix stash symbol showing during git actions
d783ba8 
The git stash symbol must never show during a git action, similar to
arrows. It even showed up during an action without opt-in.

Closes sindresorhus#532
@carhartl carhartl mentioned this issue Feb 20, 2020
Closed
@camsteffen
Copy link
Contributor Author

So in general we don't want the symbol to appear during an action, correct?

My bug title might be misleading. I think it should appear if the feature is enabled and there is a stash.

@camsteffen
Copy link
Contributor Author

I just noticed your commit message which notes that the arrows are not shown during a git action. So maybe it makes since to also not show the stash symbol. But I think the stash symbol is still relevant during a git action. Sorry for all the comments!

@camsteffen camsteffen mentioned this issue Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@carhartl @sindresorhus @camsteffen