Fix passing empty fragmentIdentifier to stringifyUrl()

Fixes #380
sindresorhus · Feb 26, 2024 · cc232cb · cc232cb
1 parent 50271f2
commit cc232cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/base.js b/base.js
@@ -489,7 +489,7 @@ export function stringifyUrl(object, options) {
 	}
 
 	let hash = getHash(object.url);
-	if (object.fragmentIdentifier) {
+	if (typeof object.fragmentIdentifier === 'string') {
 		const urlObjectForFragmentEncode = new URL(url);
 		urlObjectForFragmentEncode.hash = object.fragmentIdentifier;
 		hash = options[encodeFragmentIdentifier] ? urlObjectForFragmentEncode.hash : `#${object.fragmentIdentifier}`;

diff --git a/test/stringify-url.js b/test/stringify-url.js
@@ -27,6 +27,7 @@ test('stringify URL with fragment identifier', t => {
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar', query: {}}), 'https://foo.bar');
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar', query: {}, fragmentIdentifier: 'foo bar'}), 'https://foo.bar#foo%20bar');
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar/', query: {}, fragmentIdentifier: '/foo/bar'}), 'https://foo.bar/#/foo/bar');
+	t.is(queryString.stringifyUrl({url: 'https://foo.bar/#foo', query: {}, fragmentIdentifier: ''}), 'https://foo.bar/');
 });
 
 test('skipEmptyString:: stringify URL with a query string', t => {