-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing/stringifying fragment identifier #222
Conversation
The name is "fragment identifier", not "fragment". "fragment" feels a bit too generic. Can you also add it to the readme? |
@sindresorhus Done |
Can you fix the merge conflict? |
|
@M4rk9696 Bump |
Bump |
65eb3fe
to
ee92289
Compare
Sorry, got busy with some work. I've made the changes except the typing. Any further changes I'll get it done ASAP and we'll get this closed soon |
66379d5
to
05a4385
Compare
Co-authored-by: Karuppiah <karuppiah7890@gmail.com>
@sindresorhus Made the changes |
Co-authored-by: Karuppiah <karuppiah7890@gmail.com>
Co-authored-by: Karuppiah <karuppiah7890@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Made the changes |
@Mark1626 How about this feature 😂 excute queryString.parseUrl('https://foo.bar?query=1#/hashpath?hashquery=1', { parseFragmentIdentifier: true }) now {
"url": "https://foo.bar",
"query": {
"query": "1"
},
"fragmentIdentifier": "/hashpath?hashquery=1"
} expect {
"url": "https://foo.bar",
"query": {
"query": "1"
},
"params": {
"hashquery": "1"
},
"fragmentIdentifier": "/hashpath?hashquery=1"
} |
Fixes #220
Add a new option
parseFragment
, which will provide the hash in theparseURL
result. The new option is to prevent it from becoming a breaking changeSeems
Fragment Identifier
is the technical jargon for it, let me know if it's ok or hash seems like a better choicecc\ @sindresorhus