-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsePackage
method, bump dependencies, target Node 16
#29
Merged
sindresorhus
merged 13 commits into
sindresorhus:main
from
tommy-mitchell:feat-parse-package
Apr 7, 2023
Merged
Add parsePackage
method, bump dependencies, target Node 16
#29
sindresorhus
merged 13 commits into
sindresorhus:main
from
tommy-mitchell:feat-parse-package
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-mitchell
commented
Apr 6, 2023
tommy-mitchell
commented
Apr 6, 2023
tommy-mitchell
commented
Apr 6, 2023
tommy-mitchell
commented
Apr 6, 2023
tommy-mitchell
changed the title
Add
Add Apr 6, 2023
parsePackage
method, bump dependencies and Node.js versionparsePackage
method, bump dependencies, target Node 16
Current checks: const isObject = packageFile !== null && typeof packageFile === 'object' && !Array.isArray(packageFile);
const isString = typeof packageFile === 'string';
if (!isObject && !isString) {
throw new TypeError('`packageFile` should be either an `object` or a `string`.');
}
// Input should not be modified - if `structuredClone` is available, do a deep clone, shallow otherwise
const clonedPackageFile = isObject
? (globalThis.structuredClone === undefined
? {...packageFile}
: structuredClone(packageFile))
: packageFile; |
tommy-mitchell
commented
Apr 6, 2023
sindresorhus
reviewed
Apr 7, 2023
sindresorhus
reviewed
Apr 7, 2023
@sindresorhus whoops, left in a typo (trailing slash): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28.
Adds a new
parsePackage
method that operates on objects and strings:I've bumped the dependencies and the minimum Node.js version as well, so this is a breaking change. With the
AVA
version bump, I've changed to test script so that we don't have to pass--no-worker-threads
and useprocess.chdir()
: