Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Fix slow scrolling area repaint #14

Merged
merged 3 commits into from
Dec 11, 2017

Conversation

ivancuric
Copy link
Contributor

Promotes two offending elements to their own layers.

image
https://twitter.com/_baxuz/status/939065264410382336

@sindresorhus
Copy link
Owner

This only improves scroll performance when a single-tweet is modal, right?

@sindresorhus
Copy link
Owner

Can you add something like - Improves the performance of twitter.com to https://github.com/sindresorhus/refined-twitter#highlights and make it link to here?

@ivancuric
Copy link
Contributor Author

ivancuric commented Dec 11, 2017

This only improves scroll performance when a single-tweet is modal, right?

Yes and no. The RichEditor-tempTextArea sometimes remains rendered after you close it as a zero-height fixed position element causing repaints even when the modal is closed. I haven't found the cause, it's probably a state/race condition bug on their end.

Can you add something like - Improves the performance of twitter.com to sindresorhus/refined-twitter#highlights and make it link to here?

Will do.

@sindresorhus sindresorhus merged commit 514239a into sindresorhus:master Dec 11, 2017
@sindresorhus
Copy link
Owner

Awesome! Any other performance improvements more than welcome :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants