Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES2015ify #3

Merged
merged 1 commit into from
Apr 27, 2017
Merged

ES2015ify #3

merged 1 commit into from
Apr 27, 2017

Conversation

SamVerschueren
Copy link
Contributor

@SamVerschueren SamVerschueren commented Apr 27, 2017

Hold your 🐴 with a new release though, want to do some minor tweaks in a follow up PR.

  • .editorconfig
  • Seperate error handling for fromDir and moduleId (if you want to)
    • Expected fromDir to be of type string, got number
    • Expected moduleId to be of type string, got boolean

@sindresorhus
Copy link
Owner

No rush. sindresorhus/import-from#1 (comment) needs to be done before a major release too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants