Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Caps cause incorrect dashes! #35

Closed
ahmadawais opened this issue Jul 12, 2019 · 0 comments · Fixed by #36
Closed

All Caps cause incorrect dashes! #35

ahmadawais opened this issue Jul 12, 2019 · 0 comments · Fixed by #36
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ahmadawais
Copy link

I am well aware of , {decamelize: false}.

Wanted to report an edge case.

slugify('JAMstack Conf London 2019') 
// ja-mstack-conf-london-2019

I think it should do jam-stack-conf-london-2019 in case, where all the caps are considered one single word.
@TiagoDanin TiagoDanin mentioned this issue Jul 14, 2019
Merged
@sindresorhus sindresorhus added bug Something isn't working help wanted Extra attention is needed labels Nov 29, 2019
@TiagoDanin TiagoDanin mentioned this issue Feb 17, 2020
Merged
TiagoDanin added a commit to TiagoDanin-Forks/slugify that referenced this issue Feb 17, 2020
@TiagoDanin
Revert fix to incorrect dashes (sindresorhus#35)
3e1f521
sindresorhus pushed a commit that referenced this issue May 7, 2020
@TiagoDanin
Revert fix to incorrect dashes (#35) (#45)
1be97b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate capitalized words TiagoDanin-Forks/slugify
2 participants
@sindresorhus @ahmadawais