Add TypeScript definition #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide? |
sindresorhus
requested changes
Feb 14, 2019
| * @param separator - The separator to split on. | ||
| * @returns The string split on the separator, if possible. | ||
| */ | ||
| declare function splitOnFirst(string: string, separator: string): [string, string?]; |
There was a problem hiding this comment.
You don't need to declare. You can just export it directly.
| * | ||
| * @param string - The string to split. | ||
| * @param separator - The separator to split on. | ||
| * @returns The string split on the separator, if possible. |
There was a problem hiding this comment.
This is unclear. It makes it seem it returns the string. Should be clearer.
|
Ping :) |
|
Closing in favor of #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.