Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a prefix for temp directory #20

Merged
merged 15 commits into from
Jul 18, 2020
Merged

Allow setting a prefix for temp directory #20

merged 15 commits into from
Jul 18, 2020

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Jan 18, 2020 •
edited
Loading

Signed-off-by: Richie Bendall richiebendall@gmail.com

cc @sindresorhus

@Richienb
feat: Allow setting a prefix for temp directory
fb5d030 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
chore: Fix lint
69548ed 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus
Copy link
Owner

What's the use-case for this? What problem are you trying to solve?

@Richienb
Copy link
Contributor Author

@sindresorhus

Allow developers to easily find the cache directories created by a particular application for faster debugging.

@sindresorhus
Copy link
Owner

Debugging of what? Can you describe how you would use this for debugging? Just a name prefix will not help much as there will probably be more than one directory.

@Richienb
Copy link
Contributor Author

@sindresorhus Having a prefix would allow us to know which application created the directory.

@sindresorhus
Copy link
Owner

Yes, but what do you do with that information?

@Richienb
Copy link
Contributor Author

Richienb commented Feb 22, 2020 •
edited
Loading

@sindresorhus

Yes, but what do you do with that information?

In my use case, my script automatically downloads and extracts a ffmpeg binary to a temporary path so, with a directory prefix, I can easily find the directory that it downloaded it to in order to check that it actually worked.

@Richienb Richienb changed the title feat: Allow setting a prefix for temp directory Allow setting a prefix for temp directory Feb 22, 2020
sindresorhus
sindresorhus requested changes Jul 16, 2020
View reviewed changes
index.d.ts Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
Richienb and others added 7 commits July 17, 2020 14:50
@Richienb
Declare options type
1ac2f4b 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Synchronise typings with readme
a78cd5a 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Add use case for prefix option
c14daa0 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Check if directory starts with the prefix
9c38bf7 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Fix test
d97a9e2 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Take prefix option via object destructuring
f2fbb13 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb @sindresorhus
Update index.js
13daf7e 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Richienb
Copy link
Contributor Author

@sindresorhus Ready for re-review!

@sindresorhus
Copy link
Owner

Travis is failing

@Richienb
Fix merge
6654464 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus sindresorhus merged commit f7fc51f into sindresorhus:master Jul 18, 2020
This was referenced Mar 17, 2021
Closed
Closed
@abdulrahman305 abdulrahman305 mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richienb @sindresorhus