Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index signatures support on Merge and improve performances #455

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

skarab42
Copy link
Collaborator

@skarab42 skarab42 commented Sep 1, 2022

This PR adds support for index signatues requested in #382 and by the way it improves performance by reducing the number of instantiations by ~4 times #304.

Fix #304
Fix #382

@skarab42
Copy link
Collaborator Author

skarab42 commented Sep 1, 2022

@sindresorhus I have to do the same thing in the deep version.

@skarab42
Copy link
Collaborator Author

skarab42 commented Sep 1, 2022

// @chbdetta @augustobmoura

@sindresorhus sindresorhus merged commit 850ac04 into sindresorhus:main Sep 1, 2022
@sindresorhus
Copy link
Owner

Very nice! 👍

@skarab42 skarab42 deleted the fix-merge-index-signature branch September 1, 2022 10:01
@augustobmoura
Copy link

Thanks, @skarab42! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge is not that useful with indexed types Merge type increases type instantiations count drastically
3 participants