Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DelimiterCasedPropertiesDeep: Don't recurse into intersection type that included primitive value #789

Merged
merged 1 commit into from
Jan 4, 2024
Merged

DelimiterCasedPropertiesDeep: Don't recurse into intersection type that included primitive value #789

merged 1 commit into from
Jan 4, 2024

Conversation

Emiyaaaaa
Copy link
Collaborator

Core changes are similar to

- Value extends Function | Date | RegExp ? Value : ...
+ Value extends Function | Date | RegExp | Primitive ? Value : ...

To ensure the intersection type that included Primitive value like number & {} Don't be recursed.

@sindresorhus sindresorhus merged commit eb96609 into sindresorhus:main Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voxpelli voxpelli Awaiting requested review from voxpelli voxpelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opaque does not work with case changes (ie. SnakeCasedProperties, etc)
2 participants
@Emiyaaaaa @sindresorhus