Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export (Split)Words #975

Merged
merged 6 commits into from
Nov 14, 2024
Merged

export (Split)Words #975

merged 6 commits into from
Nov 14, 2024

Conversation

eranhirsch
Copy link
Contributor

The SplitWords utility is not under the /internal/ directory, but isn't exported.

Would it be OK to export it? I want to use it for some types in https://github.com/remeda/remeda

@eranhirsch eranhirsch changed the title feat: export SplitWords export SplitWords Nov 3, 2024
@sindresorhus
Copy link
Owner

It needs a better name. SplitWords makes it sound it actually splits the words themselves. Should be something like SplitOnWords or WordSplit. You also need to remove @internal.

@eranhirsch
Copy link
Contributor Author

eranhirsch commented Nov 5, 2024

Would Words be sufficient?

@sindresorhus
Copy link
Owner

👍

@eranhirsch eranhirsch requested a review from voxpelli as a code owner November 10, 2024 14:23
@eranhirsch eranhirsch changed the title export SplitWords export ~~Split~~Words Nov 10, 2024
@eranhirsch eranhirsch changed the title export ~~Split~~Words export (Split)Words Nov 10, 2024
@voxpelli
Copy link
Collaborator

Noting that #930 is also touching / changing this

@sindresorhus sindresorhus merged commit 13c0c83 into sindresorhus:main Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants