Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnerability CVE-2020-7598 is introduced by package minimist #65

Closed
ayaka-kms opened this issue Aug 10, 2021 · 3 comments
Closed

vulnerability CVE-2020-7598 is introduced by package minimist #65

ayaka-kms opened this issue Aug 10, 2021 · 3 comments
Labels

Comments

@ayaka-kms
Copy link

ayaka-kms commented Aug 10, 2021

Hi, a vulnerability CVE-2020-7598 is introduced in hads@3.0.0 via:
● hads@3.0.0 ➔ optimist@0.6.1 ➔ minimist@0.0.10

However, optimist is a legacy package, which has not been maintained for about 8 years.
Is it possible to migrate optimist to other package to remediate this vulnerability?

I noticed several migration records in other js repo for optimist:

  1. in handlebars, version 4.7.3-->4.7.4, migrate optimist to yargs via commit
  2. in db-migrate, version 1.0.0-beta.2-->1.0.0-beta.3, migrate optimist to yargs via commit
  3. in http-server, version 0.12.1-->0.12.2, deprecated optimist and directly use minimist via commit

Thanks.

@sinedied
Copy link
Owner

You're completely right, in most of my other projects I use minimist directly so I've failed to notice. I would be fine with migrating to either minimist or yargs, both are solid choices.

@sinedied sinedied added chore Maintenance task PR-welcome labels Aug 17, 2021
@ayaka-kms
Copy link
Author

@sinedied Thanks for your answer.

sinedied pushed a commit that referenced this issue Sep 14, 2021
## [3.0.1](3.0.0...3.0.1) (2021-09-14)

### Bug Fixes

* remove highlight warning ([e9fd47e](e9fd47e))
* use yargs instead of optimist (fixes [#65](#65)) ([d311d00](d311d00))
@sinedied
Copy link
Owner

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants