Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen Deserialize Decimal precision #33

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

dmosorast
Copy link
Contributor

Description of change

The tap errors in the case that a value exceeds 38 precision. In most warehouses, this is an error, but that's not for the tap to decide. However, knowing when rounding occurs during extraction is good, so trapping the signal from the Python decimal module is acceptable.

This PR expands the precision to match the max width of a singer.decimal (just to be consistent, even though this tap does not use more dynamic schemas).

Manual QA steps

  • Manually reproduced a case where a value would throw a Rounding error, confirmed it's fixed by this changed.

Risks

  • Low, this should just expand the range of values that the tap can emit and give developers more control over the behavior of it.

Rollback steps

  • revert this branch and release new patch version

@dmosorast dmosorast merged commit 79c652e into master Nov 2, 2021
@dmosorast dmosorast deleted the fix/expand-deserialize-decimal-precision branch November 2, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants