Widen Deserialize Decimal precision #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The tap errors in the case that a value exceeds 38 precision. In most warehouses, this is an error, but that's not for the tap to decide. However, knowing when rounding occurs during extraction is good, so trapping the signal from the Python
decimal
module is acceptable.This PR expands the precision to match the max width of a
singer.decimal
(just to be consistent, even though this tap does not use more dynamic schemas).Manual QA steps
Risks
Rollback steps