Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for incorrectly set up log based streams #50

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

leslievandemark
Copy link
Contributor

Description of change

The deserializer.deserialize_item will not return None if the incorrect object is passed in, it will throw an AttributeError: 'NoneType' object has no attribute 'items' . This PR fixes the error handling to check if the record contains NewImage before deserializing, to throw the correct actionable error.

Manual QA steps

  • tested locally with clients connection

Risks

  • low, the tap should not throw an actionable error message if log based is not set up correctly

Rollback steps

  • revert this branch

@leslievandemark leslievandemark merged commit 0e79742 into master Apr 3, 2023
@leslievandemark leslievandemark deleted the TDL-22577/fix-log-based-error-handling branch April 3, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants