Adding pull requests, assignees and collaborars to the tap #8
Conversation
|
Hi @alisaraa, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
alisaraa
changed the title
|
You did it @alisaraa! Thank you for signing the Singer Contribution License Agreement. |
tap_github/files.json
Outdated
| "url": {"type": "string"}, | ||
| "additionalProperties": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this get linted / formatted so the indentation is correct?
tap_github/reviews.json
Outdated
| }, | ||
| "additionalProperties": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this get linted / formatted so the indentation is correct?
tap_github.py
Outdated
| for filename in os.listdir(get_abs_path('tap_github')): | ||
| path = get_abs_path('tap_github') + '/' + filename | ||
| file_raw = filename.replace('.json', '') | ||
| schemas[file_raw] = json.load(open(path)) |
There was a problem hiding this comment.
Do you know if json.load() will close the file afterwards? I'm wondering if this loop should include:
with open(path) as f:
schemas[file_raw] = json.load(f)
to be safe
There was a problem hiding this comment.
you're right; I should either do a with or close it
tap_github.py
Outdated
| singer.write_records('collaborators', collaborators) | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please remove some of the extra whitespace here.
tap_github.py
Outdated
| assignees = response.json() | ||
|
|
||
| singer.write_records('assignees', assignees) | ||
|
|
There was a problem hiding this comment.
Please remove some of the extra whitespace here.
tap_github.py
Outdated
| reviews = review_response.json() | ||
| singer.write_records('reviews', reviews) | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove some of the extra whitespace here.
|
@KAllan357 Any additional work to be done here? |
|
👍 |
…o_github Adding pull requests, assignees and collaborars to the tap
I am adding code to pull the assignees and collabs or a repo as well as the pull requests.