Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a string description on an issue label #97

Closed

Conversation

jcw-
Copy link

@jcw- jcw- commented Sep 11, 2020

Description of change

Fix for #95

Manual QA steps

  • Set a description on an issue label
  • Apply the label to an issue
  • Observe that validation now succeeds

Risks

Rollback steps

  • revert this branch

@jcw-
Copy link
Author

jcw- commented Sep 11, 2020

@jacobrobertbaca minor fix to your recent addition in #92, would you be interested in reviewing?

@hassankhan
Copy link

Anything we can do to get this PR merged in soon, @KAllan357?

@luandy64
Copy link
Contributor

luandy64 commented Feb 4, 2021

@jcw- @hassankhan I'm working to get #102 merged which includes this change. Follow the status there please

luandy64 pushed a commit that referenced this pull request Feb 5, 2021
* fix issue events schema

Some of the properties were marked as "null" type.
Change them to nullable string type.

* fix milestone property

Closes #95, #97
@jcw-
Copy link
Author

jcw- commented Feb 6, 2021

Fixed with #102

@jcw- jcw- closed this Feb 6, 2021
AJWurts pushed a commit to villagelabsco/tap-github that referenced this pull request Oct 24, 2024
* fix issue events schema

Some of the properties were marked as "null" type.
Change them to nullable string type.

* fix milestone property

Closes singer-io#95, singer-io#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants