Fix/binary field schemas #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
https://stitchdata.atlassian.net/browse/SUP-910
We are converting binary fields to strings that have a length double + 2 of the actual length reported by MSSQL. For example, a
binary(4)is 4 bytes wide, which in hex translates to0xF0F0F0F0, which is 10 characters long. This fails validation, since themaxLengthon the generated schema is set to the MSSQL value of 4.This PR removes the maxLength from these data types, since they aren't providing much value beyond rejection, and it's cleaner than arbitrary arithmetic that's bound to the specific transformation that we currently have.
QA steps
Risks
Low, this makes the schema more permissive, rather than less.
Rollback steps