Merge pull request #39 from singer-io/fix-more-raise

Bubble the requests exception
singer-io · Feb 9, 2018 · c42fdc1 · c42fdc1
2 parents d23e14e + 79bcf7b
commit c42fdc1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/tap_salesforce/salesforce/__init__.py b/tap_salesforce/salesforce/__init__.py
@@ -13,8 +13,7 @@
 from tap_salesforce.salesforce.rest import Rest
 from tap_salesforce.salesforce.exceptions import (
     TapSalesforceException,
-    TapSalesforceQuotaExceededException,
-    TapSalesforceHTTPException)
+    TapSalesforceQuotaExceededException)
 
 LOGGER = singer.get_logger()
 
@@ -275,7 +274,7 @@ def _make_request(self, http_method, url, headers=None, body=None, stream=False,
         try:
             resp.raise_for_status()
         except RequestException as ex:
-            raise TapSalesforceHTTPException("Error response from Salesforce") from ex
+            raise ex
 
         if resp.headers.get('Sforce-Limit-Info') is not None:
             self.rest_requests_attempted += 1

diff --git a/tap_salesforce/salesforce/exceptions.py b/tap_salesforce/salesforce/exceptions.py
@@ -6,7 +6,3 @@ class TapSalesforceException(Exception):
 
 class TapSalesforceQuotaExceededException(TapSalesforceException):
     pass
-
-
-class TapSalesforceHTTPException(TapSalesforceException):
-    pass
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,3 @@ class TapSalesforceException(Exception): @@
     class TapSalesforceQuotaExceededException(TapSalesforceException):
         pass
-    class TapSalesforceHTTPException(TapSalesforceException):
-        pass