Skip to content

Commit

Permalink
Merge pull request #30 from singer-io/stop-streaming
Browse files Browse the repository at this point in the history
Read the dataset into memory
  • Loading branch information
KAllan357 authored Jan 17, 2018
2 parents 0f947b0 + 255c5f5 commit e13f224
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tap_salesforce/salesforce/bulk.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ def get_batch_results(self, job_id, batch_id, catalog_entry):

with metrics.http_request_timer("batch_result") as timer:
timer.tags['sobject'] = catalog_entry['stream']
result_response = self.sf._make_request('GET', url, headers=headers, stream=True)
# Removed the stream=True param because Salesforce was snapping open connections
result_response = self.sf._make_request('GET', url, headers=headers)

# Starting with a streaming generator, replace any NULL bytes in the line given by the CSV reader
streaming_response = self._iter_lines(result_response)
Expand Down

0 comments on commit e13f224

Please sign in to comment.