Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the dataset into memory #30

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Read the dataset into memory #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tap_salesforce/salesforce/bulk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ def get_batch_results(self, job_id, batch_id, catalog_entry):

with metrics.http_request_timer("batch_result") as timer:
timer.tags['sobject'] = catalog_entry['stream']
result_response = self.sf._make_request('GET', url, headers=headers, stream=True)
# Removed the stream=True param because Salesforce was snapping open connections
result_response = self.sf._make_request('GET', url, headers=headers)

# Starting with a streaming generator, replace any NULL bytes in the line given by the CSV reader
streaming_response = self._iter_lines(result_response)
Expand Down