Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.9 __subclasscheck__ workaround #240

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Oct 28, 2024

This code dates to Feb '23, doesn't seem to be necessary for tests/CI (including Typeguard and mypy) to pass, and seems to be causing issues in TileDB-SOMA CI (e.g. single-cell-data/TileDB-SOMA#3246).

Here's a sweep of:

Screenshot 2024-10-28 at 2 57 50 PM

Notes:

  • Typeguard 4.2.1: everything passes. Typeguard added more checks and fixes in 4.3.0 and 4.4.0…
  • Typeguard 4.3.0: everything fails, errors refer to __orig_bases__.
  • Typeguard 4.4.0: Python 3.9 fails on main, everything passes on this branch.

I've been unable to find a situation where the __subclasscheck__ block here is necessary; my best guess (and from discussing with @jp-dark) is that it was relevant to older Typeguard versions (TileDB-SOMA would have been on 2.x when this code was added, in Feb '23). I've locally tested Python versions 3.9.{4,7,10,11,13,19}, they all seem to have the same behavior (failure with Typeguard 4.4.0 and this code present, OK without this code, OK on 4.2.1 with and without this code).

Here's TileDB-SOMA CI passing when pointed at this branch (single-cell-data/TileDB-SOMA#3250).

It seems to be causing issues in TileDB-SOMA CI
(single-cell-data/TileDB-SOMA#3246),
and it doesn't seem to be necessary for any tests.
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ryan-williams ryan-williams merged commit 088a243 into main Oct 28, 2024
6 checks passed
@ryan-williams ryan-williams deleted the rw/slc branch October 28, 2024 21:18
@johnkerl johnkerl changed the title rm py3.9 __subclasscheck__ workaround Remove Python 3.9 __subclasscheck__ workaround Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants