Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_fast_csr type fix, docstr/pre-commit tweaks #242

Merged
merged 3 commits into from
Nov 1, 2024
Merged

_fast_csr type fix, docstr/pre-commit tweaks #242

merged 3 commits into from
Nov 1, 2024

Conversation

ryan-williams
Copy link
Member

_CSRAccumulator declares {obs,var}_joinids args of type npt.NDArray[np.int64], but was passed pa.Arrays.

@ryan-williams ryan-williams marked this pull request as draft November 1, 2024 14:44
@ryan-williams ryan-williams marked this pull request as ready for review November 1, 2024 14:55
@ryan-williams ryan-williams merged commit 1f9317d into main Nov 1, 2024
6 checks passed
@ryan-williams ryan-williams deleted the rw/idx branch November 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkmartinjr bkmartinjr bkmartinjr approved these changes

@johnkerl johnkerl Awaiting requested review from johnkerl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-williams @bkmartinjr