Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR #6 #15

Merged
merged 4 commits into from
Oct 1, 2024
Merged

CR #6 #15

merged 4 commits into from
Oct 1, 2024

Conversation

ryan-williams
Copy link
Member

A few changes I accumulated while reading #6 (merging this PR will update #6):

  • I don't think we need the dependency on attrs; dataclasses does what we need, in the stdlib
  • Specify 3.11 for pre-commit tools in pyproject.toml (to match GHA)
  • Use SOMA_JOINID instead of "soma_joinid"
  • Some suggested type-alias/comment/docstring tweaks

The commits should be relatively self-contained, in case that's an easier way to browse the changes in isolation.

I don't feel strongly about these, happy to discuss!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions (attrs and SOMA_JOINID), but otherwise these are all great changes. Lets sort out the aforementioned two offline.

@ryan-williams ryan-williams merged commit cd51799 into bkmartinjr/initial-non-shuffling-code Oct 1, 2024
24 checks passed
@ryan-williams ryan-williams deleted the rw/pr/6 branch October 1, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants