Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Call array schema evolution after loop setting up enums #2201

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

eddelbuettel
Copy link
Contributor

Issue and/or context:

See #2197 for context and the Python example: multiple calls to evolve an array schema can have side effects.

Changes:

On write, one call is now made (as needed) which is similar to what the update process already did.

Notes for Reviewer:

SC 42531

Copy link

@eddelbuettel eddelbuettel marked this pull request as ready for review March 5, 2024 16:08
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #2201 (5036c46) into main (9134e2c) will decrease coverage by 3.85%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
- Coverage   78.54%   74.69%   -3.85%     
==========================================
  Files         137       52      -85     
  Lines       10681     4347    -6334     
  Branches      215        0     -215     
==========================================
- Hits         8389     3247    -5142     
+ Misses       2194     1100    -1094     
+ Partials       98        0      -98     
Flag Coverage Δ
libtiledbsoma ?
python ?
r 74.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma ∅ <ø> (∅)

@eddelbuettel eddelbuettel merged commit 27ff99d into main Mar 5, 2024
8 checks passed
@eddelbuettel eddelbuettel deleted the de/sc-42531/enumeration_multiple_evolve_race branch March 5, 2024 17:42
johnkerl pushed a commit that referenced this pull request Mar 5, 2024
johnkerl pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants